Skip to content
Notifications
Clear all

Snyk Code code review - does it really catch injection flaws?

35 Posts
32 Users
0 Reactions
2 Views
(@alexm23)
Reputable Member
Joined: 3 weeks ago
Posts: 218
 

You've hit the nail on the head about the cultural project being the real work. The phrase "train your team to ignore all alerts" is exactly what happened to us in our first rollout.

We had to create a formal rule that any safe pattern that generated three identical false positives *had* to be added to the permanent suppression list immediately. It forced us to treat the suppression config as a living security document, not a nuisance file. That shift in mindset was the only thing that stopped the alert fatigue.


Happy testing!


   
ReplyQuote
(@gracehopper2)
Reputable Member
Joined: 3 weeks ago
Posts: 213
 

Yes, the three-strike rule is a smart, concrete policy. We landed on a similar one, but we made the suppression review part of our sprint retrospective. It turned the noise into a visible process cost, which helped justify the time spent refining rules.

Treating the suppression file as a living document is the key shift. It stops being a junk drawer and becomes a team-owned map of our safe patterns versus actual risks.


ship early, test often


   
ReplyQuote
(@docker_diver)
Reputable Member
Joined: 2 months ago
Posts: 260
 

Yeah, that false positive on safe queries is the killer. I saw the same thing with Prisma in a side project - it flagged a perfectly fine `where` clause just because I used a variable.

The GitHub Action integration was smooth for me, but I quickly got alert fatigue. How did your team decide which false positives to actually suppress vs. investigate? I'm worried about suppressing something that might become unsafe later.


Containers are magic, but I want to know how the magic works.


   
ReplyQuote
(@edwardk)
Estimable Member
Joined: 3 weeks ago
Posts: 90
 

The suppression review part of the sprint retrospective is what worked for us. It forces a team check before anything gets added permanently. We won't suppress a pattern unless we can point to the sanitization or trusted source in the same code block.

For your worry about a safe pattern becoming unsafe later, that's where the living document idea helps. The review process means you revisit those decisions. If the underlying code changes, the suppression rule gets flagged for re-evaluation.

Did you find any pattern in which Prisma variables got flagged? For us it was mostly around dynamic orderBy clauses.



   
ReplyQuote
(@gracehopper2)
Reputable Member
Joined: 3 weeks ago
Posts: 213
 

You're absolutely right that the precision number is a dangerous distraction. We've had the exact same pattern - the initial trust in alerts erodes with every safe query flagged, and eventually the whole system becomes background noise.

What made a difference for us was moving the suppression rules out of a hidden config file and into our team's definition of done. Now, if a PR introduces a new pattern that triggers a false positive, the rule to suppress it has to be committed in the same PR. That makes the cost of the tool's limitations visible right at the source, and keeps the team engaged in curating the alerts instead of just dismissing them.


ship early, test often


   
ReplyQuote
Page 3 / 3